RSSNext / Follow

🧡 Follow your favorites in one inbox
https://follow.is
GNU General Public License v3.0
17.21k stars 714 forks source link

fix: explicitly assign a value to `cancelId` for ‘Clear All Data' dialog #1624

Closed ericyzhu closed 6 days ago

ericyzhu commented 6 days ago

Description

The Electron assigns the latin string "Yes" to the "Confirmation" action and "No" to the "Cancel" action. Although the display order of the buttons is reversed in the English UI, the value responded when pressing the ESC key is correct (index value of the "No" button). However, in the translated UI, the default value responded when pressing the ESC key is 0 (if the correct value is not assigned to cancelId), which leads to the data being cleared after pressing the ESC key.

Therefore, explicitly assign a value to cancelId.

image

PR Type

Changelog

follow-reviewer-bot[bot] commented 6 days ago

Thank you for your contribution. We will review it promptly.

vercel[bot] commented 6 days ago

@ericyzhu is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

follow-reviewer-bot[bot] commented 6 days ago

Suggested PR Title:

feat(dialog): add icon to confirmation dialog for clearing data

Change Summary: Modified the clearAllDataAndConfirm function to include an icon in the confirmation dialog, improving user interface feedback when clearing data. The addition of the icon enhances visual clarity and enhances the user experience during this operation.

Code Review: No change requests necessary.