RSSNext / Follow

🧡 Follow your favorites in one inbox
https://follow.is
GNU General Public License v3.0
17.08k stars 711 forks source link

chore(i18n): improve zh-CN.json #1647

Closed hexWars closed 3 days ago

hexWars commented 3 days ago

Description

I believe the current translation isn't quite suitable, not aesthetically pleasing, so I made some slight adjustments. image

PR Type

Linked Issues

Additional context

Changelog

follow-reviewer-bot[bot] commented 3 days ago

Thank you for your contribution. We will review it promptly.

vercel[bot] commented 3 days ago

@hexWars is attempting to deploy a commit to the RSS3 Team on Vercel.

A member of the Team first needs to authorize it.

follow-reviewer-bot[bot] commented 3 days ago

Suggested PR Title:

fix(locales): update achievement description in zh-CN.json

Change Summary: Updated Chinese localization for achievement description in the app.

Code Review: No change requests necessary.

ericyzhu commented 3 days ago

In typical localization guidelines, untranslated English nouns will be changed from plural to singular form, as there is no concept of plurality in the Chinese context.

Translation cannot be done based on personal preferences.

hexWars commented 3 days ago

In typical localization guidelines, untranslated English nouns will be changed from plural to singular form, as there is no concept of plurality in the Chinese context.

Translation cannot be done based on personal preferences.

I reviewed the Traditional Chinese translation and noticed that it includes 's' and uses an asterisk with the period, which doesn't look aesthetically pleasing.

If you believe this is unnecessary, feel free to close the PR.

hexWars commented 3 days ago

image

ericyzhu commented 3 days ago

In typical localization guidelines, untranslated English nouns will be changed from plural to singular form, as there is no concept of plurality in the Chinese context. Translation cannot be done based on personal preferences.

I reviewed the Traditional Chinese translation and noticed that it includes 's' and uses an asterisk with the period, which doesn't look aesthetically pleasing.

If you believe this is unnecessary, feel free to close the PR.

I am also a contributor, and I do not have the right to close your PR.

I don't know how the typical localization guidelines for Taiwan are defined. My comments are based on my experience. I have been involved in the localization work of projects under the Mozilla Foundation since 2004, and it has lasted for about 10 years.

hexWars commented 3 days ago

Okay, I respect your suggestion. I am about to close the PR.