search

RSSchermer / ember-rl-dropdown

Dropdown components and mixin for Ember.
MIT License
15 stars 12 forks source link

Bind handlers to fix this._super() #10

Closed jaswilli closed 9 years ago

jaswilli commented 9 years ago

Background: I'm using the rl-dropdown-component mixin and need to override the clickoutHandler but since it's being run async via Ember.run.later(), calling this._super() doesn't work.

This PR uses Ember.run.bind() to bind the mixin's event handlers so that if someone uses the mixin in their own component they're able to call this._super() as expected.

Thanks for creating this addon--it's been great to use so far.

RSSchermer commented 9 years ago

:+1: Thanks a lot for the PR!

Will merge and release as 0.4.1.