Closed samselikoff closed 9 years ago
The reasons for that line were #2 and #4. In hindsight though, I think flat out prevention of event propagation may not be the right solution. I think the solution is to make it configurable with a propagateClicks
attribute. The question is, should the default value be true
or false
. I think I'd personally prefer true
as the default, even though that would be a minor BC break.
@gutschik thoughts?
Just as easy either way, I tend to prefer BC but up to you! :)
go ahead and BC :) In my case it would be refactored pretty quickly.
Thanks for the quick feedback! I'll see if I can push out a new version tonight.
I just publish 0.5.0 which allows the click events on the rl-dropdown-toggle
and rl-dropdown
components to propagate by default. Propagation can be prevented by setting propagateClicks
to false
on either or both components.
I wanted to put a file upload label in my dropdown list
but this wasn't working because
rl-dropdown
doesn't propagate events. I had to copy + pasterl-dropdown
into my project + remove this line to get it working.Do you recall why?