search

RSSchermer / ember-rl-dropdown

Dropdown components and mixin for Ember.
MIT License
15 stars 12 forks source link

Change click propagation logic #13

Closed gutschik closed 9 years ago

gutschik commented 9 years ago

Hello again, was just updating your plugin and realized I don't have to update the templates at all, since propagation is disabled by default. Since you wrote

Propagation can be prevented by setting propagateClicks to false on either or both components.

shouldn't it behave just the other way round? Peace, Ben

RSSchermer commented 9 years ago

You're absolutely right! That's quite a silly mistake. I'll try to come up with a way to add an integration test for this to make sure it's locked down in the future.