Closed tomasznapieralski closed 8 years ago
Thank you very much for the detailed explanation and the fix!
The demo is very interesting, the Firefox behavior seems quite insane indeed. I think closing when focussing on an element outside the dropdown is a good fix :+1:
The only thing that's missing I think is unbinding the focusin event in unbindClosingEvents, could you add an unbind call there?
Ah, i missed that! Thanks :)
Thanks once again! Merging...
Published as 0.9.0
Thank you
There is an edge case bug on Firefox which doesn't trigger
click
event on input when that input has changed placeholder attribute onfocus
event.It is hard to describe that is why we have prepared a small demo :) Demo: https://jsfiddle.net/e2s21f05/8/
Run this demo on Google Chrome and Mozilla Firefox to see the difference. Test case
#2
has two variants on Firefox:Input placeholder changed on focus
wait >5 sec then click outside of input (click event counter should not increase),Input placeholder changed on focus
then click outside of input (click event counter should increase)We fixed that issue with changes made by this PR. We would like to hear your feedback :)