search

RSSchermer / ember-rl-dropdown

Dropdown components and mixin for Ember.
MIT License
15 stars 12 forks source link

Tests don't pass #24

Open Gaurav0 opened 6 years ago

Gaurav0 commented 6 years ago

Clean install, ran ember test, getting 5 failures.

RSSchermer commented 6 years ago

Hey, thanks!

I am aware of the failing tests. The underlieing issue stems from this addon being from before Ember introduced contextual components. Later versions of Ember then changed something that made the old workaround for parent-child components no longer work properly in tests, but I've been unable to figure out what exactly. As I'm no longer actively developing this addon, I've resorted to some manual testing in the dummy app as a periodically upgrade the dependencies.

So in short, I suspect the proper fix would be to refactor this addon to use contextual components, but that's not really on my agenda; it would be a breaking change for what's really a legacy addon.

If you're planning on using this in a new application, you should probably look into http://ember-basic-dropdown.com/ instead. That's basically what this addon would look like after a refactor to contextual components.

If you do happen to know a fix for the test failures that does not involve a refactor to contextual components, a PR would of course be very welcome.

Gaurav0 commented 6 years ago

I've got this as a dependency of ember-calendar.