search

RSSchermer / ember-rl-dropdown

Dropdown components and mixin for Ember.
MIT License
15 stars 12 forks source link

problem with checkbox inside dropdown since 0.2.2 #7

Closed rafal-brize closed 9 years ago

rafal-brize commented 9 years ago

I am having problems with checking checkbox with ember 1.11.3. It happened after updating from 0.2.1 to 0.2.2

This is directly from readme, only changed link to a checkbox. This must be related with the click event that was changed in 0.2.2

    {{#rl-dropdown-container class="dropdown"}}
      {{#rl-dropdown-toggle class="btn btn-default"}}
        Toggle <span class="caret"></span>
      {{/rl-dropdown-toggle}}
      {{#rl-dropdown tagName="ul" class="dropdown-menu" closeOnChildClick="a:link"}}
        {{input type="checkbox" checked=checked}}
      {{/rl-dropdown}}
    {{/rl-dropdown-container}}

Cheers!

RSSchermer commented 9 years ago

Thanks for the bug report! I'll look into it.

Is the problem that the dropdown closes when you try to click the checkbox, or wont the checkbox check/uncheck when clicked?

rafal-brize commented 9 years ago

The second thing

RSSchermer commented 9 years ago

Should be fixed in 0.3.2, let me know if it now works for you!

@gutschik This changes the way event bubbling is prevented. It should still have the same effect as what you implemented in your PRs. Let me know if it breaks things for you.

rafal-brize commented 9 years ago

Thanks! It is working now :+1:

gutschik commented 9 years ago

@RSSchermer still works like a charm ;)