search

RSSchermer / ember-rl-dropdown

Dropdown components and mixin for Ember.
MIT License
15 stars 12 forks source link

Tap elsewhere doesn't close dropdown #8

Closed samselikoff closed 9 years ago

samselikoff commented 9 years ago

Thanks for this great addon!

Clicking outside of an expanded dropdown closes it, but tapping (chrome, iOS) doesn't. Have you encountered this before, or is it a bug?

RSSchermer commented 9 years ago

That's definitely a bug, I'll look into it!

RSSchermer commented 9 years ago

I've created a new branch that should fix this: close-on-tap. Could you change the ember-rl-dropdown dependency in your package.json to use this branch:

"ember-rl-dropdown": "https://github.com/RSSchermer/ember-rl-dropdown.git#close-on-tap"

And tell me if that indeed fixes it for you and is usable?

samselikoff commented 9 years ago

I put that line in my package.json and I'm getting this error when running npm install:

npm ERR! fetch failed https://github.com/RSSchermer/ember-rl-dropdown.git#close-on-tap
npm WARN retry will retry, error on last attempt: Error: fetch failed with status code 406
RSSchermer commented 9 years ago

Hmm, could you try "github notation" instead?

"ember-rl-dropdown": "rsschermer/ember-rl-dropdown#close-on-tap"
samselikoff commented 9 years ago

Awesome, works great!

RSSchermer commented 9 years ago

The close-on-tap branch is merged into master as of 0.4.x.