Closed TJHdev closed 3 years ago
This is great 🤩 I'll need a bit more time to fully review it.
Checked the code it looks good. The use of CSS variables and data attributes is brilliant 👏
Added couple of comments around code improvements, before merging. The most critical is not to change the selectedScreen
reduce structure, because this will break the app for current users.
I'll have some time on Wednesday to sort these out. Thanks for the feedback!
All the issues should be addressed in the above. The useTheme() you suggested is a lot neater. Let me know if there's anything else that stands out.
Great work 🙌 Will merge in the weekend and test with beta group and release next week.
Sounds good! Cheers again for the feedback. I've learned quite a few patterns / tricks that will be useful in my job, I particularly like the absolute paths for imports.
Couple features I'd like to have a go at after these are merged in:
Merged. Thanks. Window compability seems interesting. Haven't used windows in a while, shouldn't be that hard though.
I've added dark mode and a few small features / bug fixes. The dark mode is accessible via another page called "preferences", it's a drop down so if anyone fancies creating more themes it should only require modification to ~2 files. I've changed the structure of a couple of the reducers to allow createSlice to use typescript more readily. I think it might cause an issue when reloading state from localStorage though so I might need your input on that.
Version 0.5.0
I've replaced TodoTxtMac with FocusedTask and absolutely love it. Good job.