search

RStankov / SearchObjectGraphQL

GraphQL plugin for SearchObject gem
MIT License
159 stars 25 forks source link

Allow passing `required` key to option definition #19

Closed vfonic closed 4 years ago

vfonic commented 4 years ago

This is one of the (simplest) possible solutions for the issue I'm having described in #18.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.02%) to 97.059% when pulling cc09cc2b8388aeec243f98a56baa300f183afde1 on vfonic:accept-required-key into 1d5823657cc58a95a704d8d1833120982bf2dc12 on RStankov:master.

RStankov commented 4 years ago

This seems like correct solution. Thanks, can you write a test which passes the option?

RStankov commented 4 years ago

Thanks 🙌 Will try todo minor release with this.