search

RSully / RSColorPicker

iOS color picker view with brightness control, opacity control, and delegation support.
Other
302 stars 77 forks source link

setSelectionColor Issues #12

Closed nwoolls closed 11 years ago

nwoolls commented 12 years ago

The implementation for setSelectionColor seems hit-or-miss. For instance:

self.colorPicker.selectionColor = [UIColor blueColor]; //works self.colorPicker.selectionColor = [UIColor yellowColor]; //works self.colorPicker.selectionColor = [UIColor blackColor]; //selects green self.colorPicker.selectionColor = [UIColor redColor]; //crashes the app

kostassite commented 12 years ago

Hi, I have fixed this problem and it is in this commit. https://github.com/kostassite/RSColorPicker/commit/dcd3db19fad9b5ab3894e08edb5165164f61f4fd I have made a pull request including adding of arc in the code. Thanks

uzairbinnisar commented 12 years ago

self.colorPicker.selectionColor = [UIColor blackColor]; //selects green

it still exists and it fails on colors which are not displayed in color picker circle... it selects only those colors which come under the present brightness....

azraelx23 commented 11 years ago

So, is there any solutions to these problem? It still cannot implement :

RSully commented 11 years ago

I'm not sure that @kostassite's solution actually fixes the underlying problem. I'll see if I can look at this a little more closely soon. Feel free to try his branch and let us know what you find!

RSully commented 11 years ago

I think this issue has now been fixed in #17.