search

RSully / RSColorPicker

iOS color picker view with brightness control, opacity control, and delegation support.
Other
302 stars 77 forks source link

Corner radius on sliders #32

Closed jallen closed 10 years ago

jallen commented 11 years ago

Hi,

Not sure if you want this but I added a cornerRadius property to the the sliders a while back. I updated the example project so you can take a look.

Thanks,

Jared

RSully commented 11 years ago

Neat. I hope people don't get the wrong idea and think they have to use my custom sliders. The white circle for dragging is really out of place, but they do the job for an example.

RSully commented 11 years ago

Just to give an update, I am waiting until the next release to merge this in (i.e. not a release with only this) since it doesn't affect behavior of the picker itself.

I haven't decided if I want master to be development and to force tags as releases or if master should be a current/working release. I suspect the best option is to keep master for active development.

RSully commented 10 years ago

Given the latest bug-fix this branch can't auto-merge. If you can fix the conflicts I'd be happy to revisit it, otherwise I don't think it is quite critical enough. As mentioned in #42 the default sliders are meant to be examples. While this radius is nice, it kind if feels out of place now that the track is shown again.

jallen commented 10 years ago

Yeah, it's not really critical. It was just something I did for one of apps. Thanks anyway though.