search

RSully / RSColorPicker

iOS color picker view with brightness control, opacity control, and delegation support.
Other
302 stars 77 forks source link

While using the CGContextFillRects,CGContextAddPath and CGContextSetFillColorWithColor getting crashed in iOS 7.1 #56

Closed rajucse3040 closed 10 years ago

rajucse3040 commented 10 years ago

I'm getting the following error message while using the CGContextFillRects,CGContextAddPath and CGContextSetFillColorWithColor in ios 7.0 and in ios 7.1 it getting crashed.

CGContextFillRects: invalid context 0x0.

RSully commented 10 years ago

Could you show me your code that is causing this problem, or how to reproduce it?

RSully commented 10 years ago

Also, please test against the most up to date version in the master branch if you can.

jfclifton commented 10 years ago

I'm also having the same problem. I think iOS 7.1 is the issue here. Still runs fine when I use Xcode 5 with iOS 7.0.

Scrolls in logger with invalid context.

I am using a ViewController with a custom layout inside of a popover view if that helps.

RSully commented 10 years ago

I have been running the example project fine for the last day with iOS 7.1 simulator.

I need something more to go on to be able to reproduce this or debug it.

RSully commented 10 years ago

Alright I managed to produce a few log messages when I push a new view controller:

Mar 12 13:06:43MacBook-Pro.local RSColorPicker[62019] <Error>: CGContextSetFillColorWithColor: invalid context 0x0. This is a serious error. This application, or a library it uses, is using an invalid context  and is thereby contributing to an overall degradation of system stability and reliability. This notice is a courtesy: please fix this problem. It will become a fatal error in an upcoming update.

Edit: but it doesn't crash in debug/simulator

RSully commented 10 years ago

By removing all of the sliders the issues I saw go away. I'll try to fix them, but as stated in numerous places, these sliders are for example use only and aren't part of the public API I am deeming "RSColorPicker".

rajucse3040 commented 10 years ago

i think the most updated code have been working fine for ios 7.1. And now my issue been fixed.

RSully commented 10 years ago

@jfclifton is the issue you were seeing resolved with master (or this branch) as well?

jfclifton commented 10 years ago

@RSully I installed latest Cocoapod which is 0.8.2 I believe and I took the classes for brightness and opacity sliders from the example project and added them so all seems to be back to normal now. Why is the Brightness slider and Opacity slider no longer in Cocoapod?

RSully commented 10 years ago

The sliders are simply examples. There have been numerous issues in the past similar to this (because of the sliders). They're just meant to show how you might integrate RSColorPickerView into your own project.

Edit: of course you're free to use them, but they're mostly unsupported. Of course a pull-request is always welcome to make them work better :)

jfclifton commented 10 years ago

Gotcha. Thanks! Had some ideas so I'll see what I can come up with.

massimobio commented 10 years ago

I think I the problem is found in overriding the trackRectForBounds in RSBrightnessSlider is iOS 7.1 Commenting it out fixes the problem. Need another way of hiding the UISlider track