This patch improves the atomicity of context switching by ensuring that the stack pointer (sp) and thread self updates occur simultaneously. This enhancement is crucial for maintaining thread safety and preventing potential inconsistencies during context switches.
你的解决方案是什么 (what is your solution)
Changes:
Modified cpuport.h to use ARM64_THREAD_REG for thread self access.
Added an update_tidr macro in context_gcc.S to streamline thread ID updates.
Adjusted rt_hw_context_switch_to and rt_hw_context_switch to call update_tidr, ensuring atomic updates during context switches.
Cleaned up scheduler_mp.c by removing redundant thread self assignments.
请提供验证的bsp和config (provide the config and bsp)
BSP:
.config:
action:
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
[ ] 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
[ ] 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
[ ] 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
[ ] 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
[ ] 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
[ ] 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
[ ] 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
This patch improves the atomicity of context switching by ensuring that the stack pointer (sp) and thread self updates occur simultaneously. This enhancement is crucial for maintaining thread safety and preventing potential inconsistencies during context switches.
你的解决方案是什么 (what is your solution)
Changes:
cpuport.h
to useARM64_THREAD_REG
for thread self access.update_tidr
macro incontext_gcc.S
to streamline thread ID updates.rt_hw_context_switch_to
andrt_hw_context_switch
to callupdate_tidr
, ensuring atomic updates during context switches.scheduler_mp.c
by removing redundant thread self assignments.请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0
代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up