search

RT-WDF / rt-wdf_lib

RT-WDF - Real-Time Wave Digital Filter Library
92 stars 20 forks source link

Introduce namspaces for class names #4

Open m-rest opened 7 years ago

m-rest commented 7 years ago

wdfTree becomes wdf::Tree wdfTreeNode becomes wdf::TreeNode

Also, extend truncated names to

wdfTerminatedCap becomes wdf::Terminated::Capacitor wdfUnterminatedCap becomes wdf::Unterminated::Capacitor

maxprod2016 commented 7 years ago

Just a simple semantic question about the two variations of electrical components ( C, R, L ... ) ?

The daFX-16 paper talk about adapted/unadapted components where the current code name the classes as terminated/unterminated and in the same time getType return named string as adapted/unadapted.

In order to respect a clear semantic in the new organisation let me know what is the proper term to use.

m-rest commented 7 years ago

Let's stick with 'Adapted' and 'Unadapted'. Basically, I wanted to make a shift towards the terminated/unterminated wording as it is more clear from an electrical standpoint, but all the literature on WDFs uses (un-)adapted anyway and we should stick to that!

maxprod2016 commented 7 years ago

It's ok for me.