search

RTICWDT / college-scorecard

College Scorecard
https://collegescorecard.ed.gov/
312 stars 75 forks source link

bug in dev: student body 0% full time #1054

Closed hollyallen closed 9 years ago

hollyallen commented 9 years ago

https://federalist.18f.gov/preview/18F/college-choice/dev/school/?196431-Talmudical-Seminary-Oholei-Torah (new code in dev) vs https://college-choice.18f.gov/school/?196431-Talmudical-Seminary-Oholei-Torah (old code on prod)

0% full time (on dev) 100% full time (on prod)

ultrasaurus commented 9 years ago

related issue: https://github.com/18F/open-data-maker/issues/186

ultrasaurus commented 9 years ago

FYI: definitely not an issue with the data, staging with new data matches production image

note: full_time is derived from part time. On dev, part-time is null

ultrasaurus commented 9 years ago

I found the cause. This is data.ayml on production and staging:

  student.part_time_share:
    source: PPTUG_EF
    type: float
    description: Share of undergraduate, degree-/certificate-seeking students who
      are part-time
  student.PPTUG_EF2:
    source: PPTUG_EF2
    type: float
    description: Share of undergraduate, degree-/certificate-seeking students who
      are part-time

on dev

  student.part_time_share:
    source: PPTUG_EF2
    type: float
    description: Share of undergraduate, degree-/certificate-seeking students who
      are part-time
LisaGee commented 9 years ago

These look the same to me. No?

ultrasaurus commented 9 years ago

looks like we have two fields with same definition: "Share of undergraduate, degree-/certificate-seeking students who are part-time"

PPTUG_EF was identified to us long ago as the field we should use for consumer tool. Recent naming caused both fields to have same dev-friendly name, which meant last one won. I think one should be named something else, just not sure what it should be.

ultrasaurus commented 9 years ago

this is fixed on staging: https://federalist.18f.gov/preview/18F/college-choice/staging/school/?196431-Talmudical-Seminary-Oholei-Torah

image

ErieMeyer commented 9 years ago

Looks great on staging! ![Uploading Screen Shot 2015-09-05 at 10.51.56 AM.png…]()