RTIInternational / biocloud_docker_tools

Docker library providing a catalog of images for RTI's cloud-based bioinformatics toolkit.
https://hub.docker.com/u/rtibiocloud
5 stars 11 forks source link

Initial commit: Added Dockerfile and README for Cell Ranger software #19

Closed jaamarks closed 1 year ago

jaamarks commented 1 year ago

Initial commit for Cell Ranger software tool: https://www.10xgenomics.com/support/software/cell-ranger

We did not include the human genome reference since it would make the docker image over 32GB.

jaamarks commented 1 year ago

A few comments, do you typically try and build the docker before approving it? Or do you just trust that the developer has done this prior to submitting the pull request?

Whoever is reviewing it should try to build the docker image before approving it. This brings up a good point though, maybe we should add a short section on Reviewing a PR to our https://github.com/jaamarks/biocloud_docker_tools/tree/master#dockerfile-best-practices-checklist

I'm thinking:

jaamarks commented 1 year ago

@jkstratford, thanks for the review. I believe I have addressed all of your comments. @rmathur87, would appreciate a quick review if you have time also.