RTIInternational / biocloud_docker_tools

Docker library providing a catalog of images for RTI's cloud-based bioinformatics toolkit.

https://hub.docker.com/u/rtibiocloud

5 stars 11 forks source link

Add handling of RVtest AF output format #23

Closed kliao12 closed 1 year ago

kliao12 commented 1 year ago

Description

Added handling of RVtest AF format (overallAF:caseAF:ctrlAF) on lines 291-304 that required 1) splitting the string on ":" 2) extracting overall AF and 3) converting to numeric.

Dockerfile Structure and Organization:

[ ] Does the Dockerfile build?
[ ] Is tool organized according to Repository Structure?
[ ] Specific base image with a version tag, e.g., FROM ubuntu:20.04 instead of FROM ubuntu.
[ ] Add comments to describe each Dockerfile step.

Metadata

Include the following LABELs:

[ ] LABEL maintainer="Your Name <your.email@rti.org>"
[ ] LABEL description="Short description of the purpose of this image"
[ ] LABEL software-website="https://example.com"
[ ] LABEL software-version="1.0.0"
[ ] LABEL license="https://www.example.com/legal/end-user-software-license-agreement"

File and Resource Management:

[ ] Store scripts, files, and software tools ONLY in /opt.
[ ] Removing tar files after extraction and delete temporary files and caches generated during the build process.
[ ] Ensure sensitive data (e.g., API keys, passwords) is not hardcoded in the Dockerfile.

Container Behavior

[ ] Specify a meaningful CMD to define how the container should run by default (help message is a good default).