search

RTIInternational / gobbli

Deep learning with text doesn't have to be scary.
Apache License 2.0
275 stars 23 forks source link

Missing Dockerfiles #9

Closed jacobdanovitch closed 5 years ago

jacobdanovitch commented 5 years ago

System Information

Description

It seems as though the Dockerfiles for the models (i.e., site-packages/gobbli/models/use) are missing when installed from pip. Not sure if I've done something wrong. I assume this can simply be fixed by building from source and running pip install -e . - will try to check later.

Code for Minimal Reproducible Example

pip install gobbli

Output

APIError: 500 Server Error: Internal Server Error ("Cannot locate specified Dockerfile: Dockerfile")

My current fix was to just wget all the missing files and such but I will try to install from source rather than pip.

P.S. Awesome work on this library, the results have been great so far.

jasonnance commented 5 years ago

Interesting... No, you're right -- I don't see the Dockerfiles when downloading the source from PyPI. I guess I need to configure something somewhere to make sure they get uploaded? I'll look into it.

jasonnance commented 5 years ago

Added Dockerfiles to MANIFEST.in and verified they're showing up on PyPI now under the new release (0.0.3). Apologies for the rather egregious oversight... Thanks for the report!

jacobdanovitch commented 5 years ago

Added Dockerfiles to MANIFEST.in and verified they're showing up on PyPI now under the new release (0.0.3). Apologies for the rather egregious oversight... Thanks for the report!

No worries! Thanks for the quick fix, I'll give it a go again a bit later.

jacobdanovitch commented 5 years ago

Was trying out the augment modules and the BERTMaskedLM module is experiencing the same problem - looking at the site-packages/gobbli again, it seems that the Dockerfile isn't included for it.

It is there for the models, though.

jasonnance commented 5 years ago

Ugh, you're right -- I reproduced that and found a few other issues with the wheel and source distribution. Hopefully I've got it all this time. Uploaded a new release (0.0.5) and verified I can build a model from gobbli.model and gobbli.augment from the version installed by pip install gobbli via both wheel and source. Thanks for your patience and please report back if you have any other issues!