Closed michael-long88 closed 2 years ago
This looks good and makes sense to me. Can you edit the jsdoc description to match the description you put into the API documentation? I actually auto-generate that when we make API changes, so I think as written your description will get overwritten by that. You can run npm run docs:generate
to auto-generate the API docs before committing too.
This PR is designed to allow developers to decide whether the values returned from
getDistinctValues()
are sorted. The idea being that if you already have chronologically sorted data, it would be more convenient to get the distinct values in that same order.