search

RTKConsortium / RTK

Reconstruction Toolkit
Apache License 2.0
241 stars 143 forks source link

ENH: Change default value of OSEM regularization to 0 #523

Closed arobert01 closed 1 year ago

SimonRit commented 1 year ago

Do you now think it's better like this?

arobert01 commented 1 year ago

Yes, on second thought, I think it's better to have the "classical" behavior of the MLEM/OSEM algorithm by default. Furthermore, the weight of the regularization depend of the distribution that one want to reconstruct so it would be better to let the user choose this value if needed.

SimonRit commented 1 year ago

One test is now failing so the regularization parameter should be set in it? https://my.cdash.org/index.php?project=RTK

arobert01 commented 1 year ago

Sorry I didn't see the fail. Yes we could add the regularization parameter in the test or change a little bit the threshold of the MSE for the test (the MSE is 451.23 instead of 450). What do you think is better ?

SimonRit commented 1 year ago

No preference.