search

RTKConsortium / RTK

Reconstruction Toolkit
Apache License 2.0
245 stars 145 forks source link

Standardize Phantom Format to Forbild #634

Closed axel-grc closed 7 hours ago

axel-grc commented 2 weeks ago

Summary: This merge request updates RTK to use only the Forbild phantom format for geometry definitions. All other phantom formats have been deprecated or removed for consistency and simplicity.

Key Changes: -Remove option SetIsForbildConfigFile in rtkprojectgeometricphantom and rtkdrawgeometricphantom -Create documentation on how to create a Phantom in the forbild format. -Adapt FDK example with new forbild phantom format

acoussat commented 2 weeks ago

It looks like your pull request is malformed, as it contains commits that were already submitted in other pull requests (for instance e401be8 which comes from #633). I think you should rebase your branch forbild-as-default back onto master while dropping the unnecessary commits on the way, just to keep the pull requests atomic. Feel free to ask if you need help in doing so!