RTLSponge / CreeperMend

1 stars 0 forks source link

Blocks currently duplicate. #1

Open ryantheleach opened 8 years ago

ryantheleach commented 8 years ago

Whenever an explosion happens, blocks currently duplicate.

This is because there is no possible way to work out what drops belong to which block, or that they are even caused by an explosion.

ryantheleach commented 8 years ago

Waiting on https://github.com/SpongePowered/SpongeAPI/issues/916

ryantheleach commented 8 years ago

Blocks no longer duplicate, but they do overwrite anything placed inside the explosion when the heal happens.

The fix was hacky, so I will leave this issue open until it's been fixed.

Lunaphied commented 8 years ago

I suggest a look at https://github.com/WMCAlliance/Creepair. I think the solution there was pretty clean.

ryantheleach commented 8 years ago

The biggest problem I was having that was preventing logging the items dropped was the blocksnapshot wasn't in the cause, this should be resolved as of https://github.com/ryantheleach/CreeperMend/commit/36263474a337d5bd05a79fd590ea3cde398180d7 and https://github.com/SpongePowered/SpongeCommon/commit/522b3c5376c2e6cf6f21ff9787833fc57047d281