RTXI / rtxi

Tutorials, FAQs, and more at http://rtxi.org/docs
GNU General Public License v3.0
53 stars 15 forks source link

Oscilloscope UI doesn't update properly when plotting input channels for modules #68

Closed sudorook closed 9 years ago

sudorook commented 9 years ago

When plotting the inputs to modules (neuron in this case), the oscilloscope UI will revert back to the 'disabled' appearance when "Apply" is hit to enable a channel, but it will still plot the signal like it's supposed to.

See the below screenshot. The signal-generator is connected to the neuron module. The signal waveform is in red, and Iapp for the neuron module in blue. Notice that the UI for Iapp has buttons greyed out, as if the Iapp channel is disabled in the oscilloscope.

screenshot from 2015-05-26 19 15 28

This behaviour changes when the the Vm output of the neuron module is enabled. Instead of the oscilloscope showing neuon's Iapp being disabled, it is enabled, even if it's not being plotted. See below: screenshot from 2015-05-26 19 24 13

It seems the UI is looking at the state of the Output channel of the module to determine the state of the Input channel.

yapatel commented 9 years ago

I am unable to reproduce this error; please pull the latest master branch, recompile, and verify that you are using the latest version Help->About RTXI (should show rc3).

sudorook commented 9 years ago

The issue was already fixed on the master branch. All that was needed was to pull them into the qt5 branch.