Open saramsey opened 1 year ago
Tagging @amykglen for her concurrence
These two entries in predicate-remap.yaml
also need object aspect qualifiers, do they not?
Lili I think the last two commits should fix it. Please have a look and let me know if you see any issues. Thanks.
Note, I also fixed a bunch of other issues with predicate-remap.yaml
including use of predicates that are now mixins.
This is the only relation with a qualified_predicate
that is not biolink:affects
. Overall, this looks a little weird, so we are going to get rid of it.
@ecwood by "get rid of it", do you mean convert it to:
GOREL:0002003:
operation: keep
core_predicate: biolink:affects
@saramsey I deleted the qualified_predicate
line, but kept the qualifiers. I'm not sure if that is valid:
in
predicate-remap.yaml
, shouldn't this line actually beupregulated
, which is more specific and a closer map to the source predicateGO:positively_regulated_by
?https://github.com/RTXteam/RTX-KG2/blob/bbb3366dbeff8e3cf6dd1faf492184af4a14a56f/predicate-remap.yaml#L2547C1-L2547C1