RTXteam / RTX-KG2

Build system for the RTX-KG2 biomedical knowledge graph, part of the ARAX reasoning system (https://github.com/RTXTeam/RTX)
MIT License
39 stars 8 forks source link

Drop LOINC from KG2 #307

Closed saramsey closed 1 year ago

saramsey commented 1 year ago

The LOINC UMLS source seems to take a very long time to ETL (last report was 29 hours). Unclear what benefit it brings, given the huge time cost to ETL it. Considering dropping it from the KG2.8.5pre build and beyond. We can discuss here.

saramsey commented 1 year ago

@edeutsch wrote:

I don't think the SRI Node Normalizer has LOINC identifiers, so we probably won't get LOINC identifiers in queries. But I don't know what kinds of edges it might have that are useful.

@dkoslicki wrote:

I don't know of places where it's vital either; not to say it isn't, I just don't see LOINC stuff that often (which likely speaks to its useful/lessness)

ecwood commented 1 year ago

We have decided to drop LOINC starting with KG2.8.4.

ecwood commented 1 year ago

The report comparison step noted that all of LOINC was removed in KG2.8.4pre, so I am going to close out this issue.

saramsey commented 1 year ago

Farewell, LOINC!