search

RTXteam / RTX-KG2

Build system for the RTX-KG2 biomedical knowledge graph, part of the ARAX reasoning system (https://github.com/RTXTeam/RTX)
MIT License
39 stars 8 forks source link

UniProtKB shouldn't have KB in the CURIE prefix? #348

Closed dkoslicki closed 1 year ago

dkoslicki commented 1 year ago

I just noticed that we use the prefix UniProtKB:, but it appears it should be UniProt:. Eg. Note how this URL doesn't resolve: https://identifiers.org/resolve?query=UniProtKB:Q5STB3, but this one does: https://identifiers.org/resolve?query=UniProt:Q5STB3

Can be reproduced here: https://arax.ncats.io/?term=TNF image

edeutsch commented 1 year ago

Biolink chose UniProtKB: https://github.com/biolink/biolink-model/blob/37e245f7755f5878bc1bab12d822b51ae72a88c4/biolink-model.yaml#L143

Pity that Biolink and identifiers.org are out of sync.

but I think we need to go with Biolink.

dkoslicki commented 1 year ago

Ah, gotcha. So a nonissue that is kinda an issue; huh!