RTXteam / RTX

Software repo for Team Expander Agent (Oregon State U., Institute for Systems Biology, and Penn State U.)
https://arax.ncats.io/
MIT License
33 stars 21 forks source link

DRUGBANK:category predicate remap should be fixed? #1343

Closed saramsey closed 3 years ago

saramsey commented 3 years ago

I think maybe the predicate remapping entry for DRUGBANK:category (which is currently mapping to biolink:related_to) is not sufficiently precise. I think biolink:subclass_of would be a better fit. A couple of examples should be checked to corroborate this and then we can fix the entry in predicate-remap.yaml.

https://github.com/RTXteam/RTX/blob/6fa597807f3f91ce294b7b4660f563950d201f54/code/kg2/predicate-remap.yaml#L569

ecwood commented 3 years ago

Here's some examples: (the images are from the DrugBank browser)

DRUGBANK:DB00001 (Lepirudin):

image

DRUGBANK:DB00004 (Denileukin diftitox):

image

saramsey commented 3 years ago

Thank you, @ericawood. What do you think of using biolink:subclass_of? It's a bit odd, since normally we use subclass_of within an ontology and not cross-ontology. But on the other hand, it would provide more information than related_to, right?

ecwood commented 3 years ago

Thank you, @ericawood. What do you think of using biolink:subclass_of? It's a bit odd, since normally we use subclass_of within an ontology and not cross-ontology. But on the other hand, it would provide more information than related_to, right?

I agree that it seems a bit odd. However, given the wide variety of meaning of related_to, I think that more specific would be helpful in this instance to give actual meaning to the edges.

saramsey commented 3 years ago

Maybe let's go for it? We can always change our mind in the future, if something better than subclass_of becomes available in Biolink.

kvarforl commented 3 years ago

looks fixed in kg2.6.0 :)