Closed saramsey closed 2 years ago
Copying the two logfiles and the scripts that produced them, here: issue-1759.zip
So, @amykglen suggests (and @edeutsch concurs) that the probable fix for this issue is to change (in ARAX-expand), the code
mode == "ARAX"
to
mode != "RTXKG2"
so that it picks up (as True
) the case where mode
is set to asynchronous
, as in the asyncquery controller here:
https://github.com/RTXteam/RTX/blob/07285bf96f8185a5b3f538969708a345a164e65b/code/UI/OpenAPI/python-flask-server/openapi_server/controllers/asyncquery_controller.py#L27
Note that in the above testing, I have hardcoded ARAX-expand to only use BTE.
After the fix:
rt@5d5ebba937d1:/mnt/data/orangeboard/fork-test$ grep Resultify mode-test-results-syncquery-after-fix.json
"message": "Pruning any paths that are now dead ends (with help of Resultify)",
"message": "Calling Resultify from Expand for pruning",
"message": "Resultify created 1209 results",
and
sramsey-laptop:issue-1759 sramsey$ grep Resultify mode-test-results-asyncquery-after-fix.json
"message": "Pruning any paths that are now dead ends (with help of Resultify)",
"message": "Calling Resultify from Expand for pruning",
"message": "Resultify created 1209 results",
Creating a branch issue-1759
off of production
for this work.
credit for suggesting the fix 691c66f goes to @amykglen
The fix has been tested and deployed. There is dancing in the streets. closing.
Credit to @edeutsch and @amykglen for this bug report, which came out of discussions from today's Expander Agent Mini-Hackathon meeting (and motivated by a lot of painstaking work documented in #1718). Summarizing our reprex here. When I run this query:
via
/query
usingI get different logging output from ARAX-Expand than when I run using
/asyncquery
, as shown here:So it appears that when I run using
/asyncquery
, no pruning happens, which is probably why we are seeing no results in some cases like #1718 when ARAX is passed a multihop query via/asyncquery
.