RTXteam / RTX

Software repo for Team Expander Agent (Oregon State U., Institute for Systems Biology, and Penn State U.)
https://arax.ncats.io/
MIT License
33 stars 21 forks source link

ARAX should always identify itself when querying KPs #2061

Closed amykglen closed 1 year ago

amykglen commented 1 year ago

currently ARAX only identifies itself when querying KG2. we need to change that so that ARAX identifies itself when querying any KP.

this will just be a matter of removing the 'if' clause around this line: https://github.com/RTXteam/RTX/blob/66ba3cbe63b946151920547780c18df91c66352a/code/ARAX/ARAXQuery/Expand/trapi_querier.py#L323-L324

(i.e., we should always fill out the 'submitter' when sending TRAPI queries)

thinking maybe @sundareswarpullela wants to tackle this one? this is a good opportunity to practice the workflow for changing ARAX/Expand code (described here: https://github.com/RTXteam/RTX/wiki/Dev-info#best-practice-dev-workflow)

sundareswarpullela commented 1 year ago

Tests have passed and changes are complete @edeutsch .

edeutsch commented 1 year ago

This has been deployed to all the usual master places. I don't really know how to test, but fine with me to close.