RTXteam / RTX

Software repo for Team Expander Agent (Oregon State U., Institute for Systems Biology, and Penn State U.)
https://arax.ncats.io/
MIT License
34 stars 20 forks source link

`create_envelope()` DSL command returns an error #2258

Closed dkoslicki closed 2 weeks ago

dkoslicki commented 3 months ago

Apparently xDTD requires you create a message before using infer(action=drug_treatment_graph_expansion), but doing so returns

ERROR: Unrecognized command create_envelope

for the input

create_envelope()
infer(action=drug_treatment_graph_expansion,node_curie=MONDO:0007827)

It appears that create_message does work though. Any thoughts @isbluis if this is just a mis-naming of a DSL command that the UI slurped up?

saramsey commented 3 weeks ago

@dkoslicki which is the correct DSL syntax, create_message or create_envelope? Please pardon my ignorance.

dkoslicki commented 3 weeks ago

It should be create_message, but create_envelope is available from the UI DSL dropdown. So this is either a UI think (@isbluis ) or wherever that info is being pulled from. Luis, if you remind me where this comes from, (eg. the DSL readme or somewhere else in the code), I would appreciate it.

edeutsch commented 3 weeks ago

I'm not seeing it? image

dkoslicki commented 3 weeks ago

DSL, not workflow

image
isbluis commented 3 weeks ago

create_envelope() is defined in ARAX_messenger.py , but there is no mention of create_message() . The UI gathers the DSL requirements from calling the describe_me method.

I can see that create_message() is only present in ARAX_query.py, but I don't gather any info from it, and it does not have a describe_me method.

Not sure what should be done here; maybe discuss at the next AHM?

dkoslicki commented 3 weeks ago

Yeah, next AHM would be good, as it's not clear to me if we should be exposing those on the UI, and/or if create_message even does anything outside of ARAX_query.py

isbluis commented 2 weeks ago

Submitted a fix (tested in my dev area). Feel free to close once you verify fix in CI/Test.

edeutsch commented 2 weeks ago

looks like the fix works, thanks, closing!