RTXteam / RTX

Software repo for Team Expander Agent (Oregon State U., Institute for Systems Biology, and Penn State U.)
https://arax.ncats.io/
MIT License
33 stars 21 forks source link

Creative DTD/CRG edges missing knowledge_level and agent_type #2422

Open amykglen opened 2 hours ago

amykglen commented 2 hours ago

I noticed the other day that creative DTD (and also CRG) edges like the one shown below don't appear to have any attributes indicating their biolink:knowledge_level and biolink:agent_type. I know KPs are required to include those attributes on every edge, and I imagine ARAs are supposed to as well on any edges they create? (not sure whether or not it's required by translator, but even if not, I think it would be nice for users)

Screenshot 2024-11-18 at 5 10 52 PM

(that edge is from the siltuximab result for our example 2 query)

here's an example of what the knowledge_level/agent_type attributes are supposed to look like, from a CTKP edge:

Screenshot 2024-11-18 at 5 24 46 PM

we would of course need to figure out what the proper values for these are for DTD/CRG - Biolink model definitions are here.

what do others think? something we should add? (@chunyuma @kvnthomas98)

edeutsch commented 2 hours ago

I'm thinking that yes they should be labeled, probably with 'computational model' & 'prediction'