search

RTimothyEdwards / magic

Magic VLSI Layout Tool
Other
447 stars 100 forks source link

More explicit pointer truthiness check #282

Closed donn closed 7 months ago

donn commented 7 months ago

magic/database/DBio.c::DBOpenOnly calls dbReadOpen(CellDef *, bool, bool, int) with a pointer for the second argument. While technically valid C, newer compilers (Clang 16) have recently frowned upon implicit pointer-to-int conversion, requiring the flag -Wno-int-conversion or else an error is raised.

Given that there is one such instance in the codebase, I think fixing it would be the simplest solution.

RTimothyEdwards commented 7 months ago

Pulled and merged at opencircuitdesign.com.