RTimothyEdwards / magic

Magic VLSI Layout Tool
Other
446 stars 100 forks source link

ext2spice hierarchy off mode did not flatten a subcircuit #298

Open RTimothyEdwards opened 3 months ago

RTimothyEdwards commented 3 months ago

"ext2spice hierarchy off" should flatten a subcircuit until all that is left in the subcircuit are primitive devices.

However, when using the sky130 PDK, it was found that a subcircuit calling the primitive device sky130_fd_pr__rf_pnp_05v5_W0p68L0p68 did not flatten the subcircuit, which would have resolved to the primitive device name sky130_fd_pr__pnp_05v5_W0p68L0p68, but instead left the subcircuit as-is, resulting in a simulation failure because no primitive device model could be found by that name.

Something about the wrapper layout cell for the device is interfering with the flattening, presumably something in the properties used to identify it as a generated cell.

RTimothyEdwards commented 3 months ago

Version 8.3.468 fixes this issue.

But at the same time, I found that "ext2spice subcircuit descend off" does not work. There should be a way to remove subcircuits from the netlist output, regardless of whether hierarchy is turned on or off.