search

RTimothyEdwards / magic

Magic VLSI Layout Tool
Other
447 stars 100 forks source link

3 x crash fix and 1 x read uninitialized fix #314

Open dlmiles opened 1 month ago

dlmiles commented 1 month ago

The findUse() probably wants a better review to confirm the UNDO operation left in place is enough, in particular DBundo.c:812

dlmiles commented 1 month ago

I took my own suggestion after review in comment https://github.com/RTimothyEdwards/magic/pull/314#pullrequestreview-2096688410

Also looking at the lef/lefWrite.c there was another nearby site which looks like it could trigger the same problem, so I put in the same if() guard. I can also see the same check exists already around line 1560.

https://github.com/RTimothyEdwards/magic/blob/5c7217a6b2d708bc698babe5da62b70f52fee2ec/lef/lefWrite.c#L1560

There is one more site around line 1720 that is unclear if there is a risk there also.

https://github.com/RTimothyEdwards/magic/blob/5c7217a6b2d708bc698babe5da62b70f52fee2ec/lef/lefWrite.c#L1720