RTimothyEdwards / qflow

Qflow full end-to-end digital synthesis flow for ASIC designs
183 stars 36 forks source link

Fix uninitialized read in find_clock_skews #43

Closed Teemperor closed 4 months ago

Teemperor commented 2 years ago

srcdir is only used in this function to be passed down to find_clock_source and find_clock_transition but it's never initialized anywhere.

Teemperor commented 2 years ago

Actually this might require a smarter initialization routine than just 0 when I look at the code as this seems to be some kind of enum...

RTimothyEdwards commented 4 months ago

Issue has been fixed, and thank you; closing this PR.