RTradeLtd / Nexus

🦑 Nexus is the IPFS private network node orchestration and registry service for Temporal
https://dev.temporal.cloud/private
Apache License 2.0
14 stars 4 forks source link

TEM-149: node resource quotas #11

Closed bobheadxi closed 5 years ago

bobheadxi commented 5 years ago

:construction_worker: Purpose

Restrict disk, memory, and cpu

:rocket: Changes

Various refactors to accommodate this feature. Will do a detailed writeup later, have class now 😛

:warning: Breaking Changes

Label refactors - all nodes will need to be removed and recreated

Depends on https://github.com/RTradeLtd/database/pull/15

codecov[bot] commented 5 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.46%. The diff coverage is 78.62%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage    83.6%   84.05%   +0.46%     
==========================================
  Files          15       17       +2     
  Lines         713      777      +64     
==========================================
+ Hits          596      653      +57     
- Misses         76       81       +5     
- Partials       41       43       +2
Impacted Files Coverage Δ
ipfs/node.go 100% <100%> (ø) :arrow_up:
orchestrator/orchestrator.go 90.14% <100%> (+0.48%) :arrow_up:
network/ports.go 86.21% <66.67%> (+6.9%) :arrow_up:
ipfs/ipfs_utils.go 67.8% <67.8%> (ø)
ipfs/scripts.go 71.43% <71.43%> (ø)
ipfs/ipfs.go 73.36% <76.93%> (+1.79%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57b1d9b...12daa8b. Read the comment docs.

bonedaddy commented 5 years ago

@bobheadxi can you review these logs? Some errors/warnings occurred that could could just be due to the kernel I'm using.

Couple things, an issue occurred during container creation see here however the issue check during startup didn't look like it recognized the error, see here

Not sure if these are of concern or not.