search

RTradeLtd / Nexus

🦑 Nexus is the IPFS private network node orchestration and registry service for Temporal
https://dev.temporal.cloud/private
Apache License 2.0
14 stars 4 forks source link

TEM-177: network remove fix #14

Closed bobheadxi closed 5 years ago

bobheadxi commented 5 years ago

:construction_worker: Purpose

Attempt at resolving issue in ticket

:rocket: Changes

Could not reproduce issue, but found another: data directory was not being removed correctly, this PR fixes that

:warning: Breaking Changes

none

codecov[bot] commented 5 years ago

Codecov Report

Merging #14 into master will increase coverage by 0.43%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage   83.53%   83.96%   +0.43%     
==========================================
  Files          19       19              
  Lines         862      860       -2     
==========================================
+ Hits          720      722       +2     
+ Misses         93       90       -3     
+ Partials       49       48       -1
Impacted Files Coverage Δ
ipfs/client.go 71.38% <0%> (+0.58%) :arrow_up:
network/ports.go 100% <0%> (+6.9%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d3d0a79...354daac. Read the comment docs.