TEM-226: subdomain-based proxying

[bobheadxi]

:construction_worker: Purpose

allow map proxying based only on host, without /network/feature paths

:rocket: Changes

• new config option, Domain, to set domain
• subdomain handling:
  • {network_name}.{feature}.{domain}, for example: my-network.api.nexus.temporal.cloud

:warning: Breaking Changes

all network names with . in it will break. I can make the parsing more intelligent, or we can ban . in names. 🤔

todo

• [ ] make sure it works in practice
• [ ] test with swarm

[bonedaddy]

I think names with a . in it should be banned. - seems like a reasonable separator to have since it keeps it all on the same subdomain.

[bobheadxi]

Sounds good! That will have to be enforced elsewhere, probably in RTradeLtd/Temporal

[codecov[bot]]

Codecov Report

Merging #22 into master will increase coverage by 0.27%. The diff coverage is 89.89%.

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   83.16%   83.43%   +0.27%     
==========================================
  Files          27       26       -1     
  Lines        1223     1291      +68     
==========================================
+ Hits         1017     1077      +60     
- Misses        144      153       +9     
+ Partials       62       61       -1

Impacted Files	Coverage Δ
config/config.go	100% <100%> (ø)	:arrow_up:
delegator/proxy.go	100% <100%> (ø)	:arrow_up:
delegator/engine.go	85.23% <85.94%> (-0.58%)	:arrow_down:
delegator/context.go	0% <0%> (-100%)	:arrow_down:
network/ports.go	100% <0%> (+6.9%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a4636e...0fb5baa. Read the comment docs.

[bonedaddy]

There might be an issue with the dependencies in go.sum:

solidity@dark:~/go/src/github.com/RTradeLtd/Nexus$ go mod tidy
verifying github.com/grpc-ecosystem/go-grpc-middleware@v1.0.0: checksum mismatch
        downloaded: h1:BWIsLfhgKhV5g/oF34aRjniBHLTZe5DNekSjbAjIS6c=
        go.sum:     h1:Iju5GlWwrvL6UBg4zJJt3btmonfrMlCDdsejg4CZE7c=

[bonedaddy]

@bobheadxi trying to browse a gateway (https://test.gateway.nexus.temporal.cloud/ipfs/QmdovZZW93WUzdJmDkvE4xkRu4SRGyt3cxdM4wHdN6zN9D)

[bobheadxi]

Ah I know the issue - will fix asap

[bobheadxi]

@postables can you try again with 05035ce ? I've pushed up a change that disables the custom path manipulation that was needed to get the old proxy to work, so now it either uses the subdomain routing or the path-based routing (but not both at the same time)

If this works, I'm thinking of probably deprecating the latter, since this way is much better and more consistent with multiaddr

let me know if it works!

[bonedaddy]

@bobheadxi sorry for the delay, going to try and debug the issues here