search

RTradeLtd / Nexus

🦑 Nexus is the IPFS private network node orchestration and registry service for Temporal
https://dev.temporal.cloud/private
Apache License 2.0
14 stars 4 forks source link

testing: make sure all goroutines are stopped as tests are ending #23

Open bobheadxi opened 5 years ago

bobheadxi commented 5 years ago

https://github.com/uber-go/zap/issues/687#issuecomment-473382859

t.Log is safe for concurrent use, but it's not safe to call t.Log as the test is ending, which I think is causing the race detector to go off. You should make sure that any background goroutines are stopped before the test ends.

This should fix the occasional race condition warning.