search

RTradeLtd / Nexus

🦑 Nexus is the IPFS private network node orchestration and registry service for Temporal
https://dev.temporal.cloud/private
Apache License 2.0
14 stars 4 forks source link

ipfs: node remove #8

Closed bobheadxi closed 5 years ago

bobheadxi commented 5 years ago

:construction_worker: Purpose

StopNode shouldnt be removing directories

:rocket: Changes

StopNode no longer removes directories adds RemoveNode API for explicitly removing nodes

:warning: Breaking Changes

none

Todo

codecov[bot] commented 5 years ago

Codecov Report

Merging #8 into master will increase coverage by 0.39%. The diff coverage is 76.93%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #8      +/-   ##
=========================================
+ Coverage   83.12%   83.5%   +0.39%     
=========================================
  Files          15      15              
  Lines         693     709      +16     
=========================================
+ Hits          576     592      +16     
  Misses         76      76              
  Partials       41      41
Impacted Files Coverage Δ
orchestrator/orchestrator.go 89.37% <100%> (+0.48%) :arrow_up:
ipfs/utils.go 100% <100%> (ø) :arrow_up:
ipfs/ipfs.go 71.58% <66.67%> (+0.83%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b17955...e66e840. Read the comment docs.