search

RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
227 stars 40 forks source link

Remove Zip Directory Upload #399

Closed bonedaddy closed 5 years ago

bonedaddy commented 5 years ago

:construction_worker: Purpose

Zip file based directory uploads was a feature we added experimentally in dev, but never moved to production. It was never used outside of our development environment, so it's being removed, and considered an "unbreaking change" as this was a possibility since conception of the zip file based directory uploader.

This is now something that can be handled via our iPFS HTTP API reverse proxy.

:rocket: Changes

:warning: Breaking Changes

None

codecov[bot] commented 5 years ago

Codecov Report

Merging #399 into master will increase coverage by 0.68%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #399      +/-   ##
==========================================
+ Coverage   52.17%   52.84%   +0.68%     
==========================================
  Files          43       42       -1     
  Lines        4206     4035     -171     
==========================================
- Hits         2194     2132      -62     
+ Misses       1509     1434      -75     
+ Partials      503      469      -34
Impacted Files Coverage Δ
api/v2/utils.go 58.2% <ø> (+0.96%) :arrow_up:
api/v2/routes_rtfs.go 36.66% <ø> (+3.87%) :arrow_up:
api/v2/api.go 86.29% <100%> (+0.38%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bb4f3eb...745a379. Read the comment docs.

bonedaddy commented 5 years ago

Nope, this feature never left the experimental stage and never even saw real use besides testing. Iirc I can't even recall seeing this API being used in dev.