search

RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
227 stars 40 forks source link

Fix Email Based Logins #406

Closed bonedaddy closed 5 years ago

bonedaddy commented 5 years ago

:construction_worker: Purpose

Closes https://github.com/RTradeLtd/Temporal/issues/405

:rocket: Changes

Always return the username when processing login attempts

:warning: Breaking Changes

None

bonedaddy commented 5 years ago

Build failure is due to an unrelated CI issue with looking up prices on CMC

codecov[bot] commented 5 years ago

Codecov Report

Merging #406 into master will decrease coverage by 0.02%. The diff coverage is 58.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #406      +/-   ##
==========================================
- Coverage   52.56%   52.54%   -0.01%     
==========================================
  Files          43       43              
  Lines        4112     4121       +9     
==========================================
+ Hits         2161     2165       +4     
- Misses       1468     1472       +4     
- Partials      483      484       +1
Impacted Files Coverage Δ
api/v2/routes_account.go 50% <100%> (+0.58%) :arrow_up:
api/middleware/jwt.go 78.95% <44.45%> (-11.67%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6c276ce...c111ad1. Read the comment docs.