Closed bonedaddy closed 4 years ago
We could also handle temporary lookup errors over the network by reusing the old outdated value when updating the cost returns an error.
Merging #416 into master will increase coverage by
1.22%
. The diff coverage is76.2%
.
@@ Coverage Diff @@
## master #416 +/- ##
==========================================
+ Coverage 51.86% 53.08% +1.22%
==========================================
Files 43 43
Lines 4121 4151 +30
==========================================
+ Hits 2137 2203 +66
+ Misses 1511 1462 -49
- Partials 473 486 +13
Impacted Files | Coverage Δ | |
---|---|---|
utils/cmc.go | 70.59% <69.24%> (+3.93%) |
:arrow_up: |
api/v2/routes_payment.go | 25.78% <87.5%> (+9.16%) |
:arrow_up: |
queue/ipfs_cluster.go | 69.48% <0%> (+16.85%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 53b9617...d8bfe6a. Read the comment docs.
We could also handle temporary lookup errors over the network by reusing the old outdated value when updating the cost returns an error.
Good idea
:construction_worker: Purpose
Closes https://github.com/RTradeLtd/Temporal/issues/400 and enables an in-memory cache of cmc prices to prevent excessive requests.
:rocket: Changes
:warning: Breaking Changes
None