RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
227 stars 40 forks source link

Add Better Monitoring Service Detect #419

Closed bonedaddy closed 4 years ago

bonedaddy commented 4 years ago

:construction_worker: Purpose

The previous service monitoring script was brittle and doesn't properly handle all types of invocations.

:rocket: Changes

Instead of grepping on complete command and filtering, grep the count of command names, so instead of temporal queue ipfs ipns-entry we grep on queue ipfs ipns-entry

:warning: Breaking Changes

None

codecov[bot] commented 4 years ago

Codecov Report

Merging #419 into master will increase coverage by 0.39%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #419      +/-   ##
==========================================
+ Coverage   52.69%   53.08%   +0.39%     
==========================================
  Files          43       43              
  Lines        4151     4151              
==========================================
+ Hits         2187     2203      +16     
+ Misses       1476     1462      -14     
+ Partials      488      486       -2
Impacted Files Coverage Δ
queue/ipfs_cluster.go 69.48% <0%> (+16.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1e437ce...7d2dd76. Read the comment docs.

xiegeo commented 4 years ago

have you checked out monit?

bonedaddy commented 4 years ago

Not yet, I don't want to make any changes to the way Temporal is monitored just get since these scripts are used with Zabbix which works quite well