search

RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
227 stars 40 forks source link

api/v2: Add hostname to systems check HTTP response headers #421 #423

Closed u5surf closed 4 years ago

u5surf commented 4 years ago

:construction_worker: Purpose

Fixes: #421

:rocket: Changes

To add response header (X-API-Host: hostname)to request router /v2/systems/check

:warning: Breaking Changes

If the API server does not set a hostname, response cannot help returning 5XX status code.

codecov[bot] commented 4 years ago

Codecov Report

Merging #423 into master will increase coverage by 0.37%. The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #423      +/-   ##
==========================================
+ Coverage   52.69%   53.06%   +0.37%     
==========================================
  Files          43       43              
  Lines        4151     4156       +5     
==========================================
+ Hits         2187     2205      +18     
+ Misses       1476     1464      -12     
+ Partials      488      487       -1
Impacted Files Coverage Δ
api/v2/routes_utils.go 34.22% <40%> (+0.2%) :arrow_up:
queue/ipfs_cluster.go 69.48% <0%> (+16.85%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2b3ccd7...ab4e520. Read the comment docs.