RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
227 stars 40 forks source link

Misc Improvements #448

Closed bonedaddy closed 4 years ago

bonedaddy commented 4 years ago

:construction_worker: Purpose

Closes https://github.com/RTradeLtd/Temporal/issues/446, https://github.com/RTradeLtd/Temporal/issues/447

:rocket: Changes

See corresponding tickets

:warning: Breaking Changes

None

codecov[bot] commented 4 years ago

Codecov Report

Merging #448 into master will increase coverage by 0.22%. The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #448      +/-   ##
==========================================
+ Coverage    52.6%   52.82%   +0.22%     
==========================================
  Files          43       43              
  Lines        4194     4207      +13     
==========================================
+ Hits         2206     2222      +16     
+ Misses       1495     1491       -4     
- Partials      493      494       +1
Impacted Files Coverage Δ
api/v2/routes_utils.go 42.25% <0%> (-0.18%) :arrow_down:
cmd/temporal/main.go 53.19% <75%> (+0.76%) :arrow_up:
queue/mail.go 81.82% <0%> (+15.91%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 938f397...10305e0. Read the comment docs.

bonedaddy commented 4 years ago

No, that's a breaking change which would cause existing tooling to break with a flag undefined error from the command line. We should do it when we have a breaking release though