RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
227 stars 40 forks source link

test with updated ipfs and ipfs cluster #451

Closed xiegeo closed 4 years ago

xiegeo commented 4 years ago

:construction_worker: Purpose

The test environment has not been updated for a long time. We should keep up with ipfs development.

:rocket: Changes

Update the versions of ipfs and ipfs cluster, and fix any issues that arise.

:warning: Breaking Changes

Configuration and other breaking changes are to be expected. (TODO: Creat upgrade guide.)

xiegeo commented 4 years ago

@bonedaddy Any ideas with the ci time out? I think it's because of problems with bootstrap, but I can't get it fixed.

bonedaddy commented 4 years ago

It's something to do with bootstrap and rtns, the dedicated ipns publishing service we have (i think). I'm about to head to bed, but if you are still stuck by the time I wake up, I will take a look

goroutine 271 [chan send, 9 minutes]:
github.com/libp2p/go-libp2p-kad-dht.(*IpfsDHT).RefreshRoutingTable(...)
    /home/travis/gopath/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.5.0/dht_bootstrap.go:182
github.com/libp2p/go-libp2p-kad-dht.(*IpfsDHT).Bootstrap(...)
    /home/travis/gopath/pkg/mod/github.com/libp2p/go-libp2p-kad-dht@v0.5.0/dht_bootstrap.go:172
github.com/RTradeLtd/rtns.(*rtns).Bootstrap(0xc00058c680, 0xc00039aa00, 0xc, 0x10)
    /home/travis/gopath/pkg/mod/github.com/!r!trade!ltd/rtns@v0.0.12/utils.go:54 +0x25d
github.com/RTradeLtd/Temporal/queue.(*Manager).ProcessIPNSEntryCreationRequests(0xc000526840, 0x172c760, 0xc0004f38c0, 0xc00050be60, 0xc0004d3ce0, 0x0, 0x0)
    /home/travis/gopath/src/github.com/RTradeLtd/Temporal/queue/ipns.go:90 +0x52f
github.com/RTradeLtd/Temporal/queue.(*Manager).ConsumeMessages(0xc000526840, 0x172c760, 0xc0004f38c0, 0xc00050be60, 0xc00036ba00, 0xc000220700, 0xc000202a68, 0xc000526840)
    /home/travis/gopath/src/github.com/RTradeLtd/Temporal/queue/queue.go:136 +0x23b
github.com/RTradeLtd/Temporal/cmd/temporal.glob..func2(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
    /home/travis/gopath/src/github.com/RTradeLtd/Temporal/cmd/temporal/main.go:246 +0x618
github.com/RTradeLtd/Temporal/cmd/temporal.TestQueuesIPFS.func1(0xc000554800)
    /home/travis/gopath/src/github.com/RTradeLtd/Temporal/cmd/temporal/main_test.go:89 +0x1d2
testing.tRunner(0xc000554800, 0xc00030f340)
    /home/travis/.gimme/versions/go1.13.linux.amd64/src/testing/testing.go:909 +0xc9
created by testing.(*T).Run
    /home/travis/.gimme/versions/go1.13.linux.amd64/src/testing/testing.go:960 +0x350
codecov[bot] commented 4 years ago

Codecov Report

Merging #451 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   52.61%   52.61%           
=======================================
  Files          43       43           
  Lines        4218     4218           
=======================================
  Hits         2219     2219           
  Misses       1504     1504           
  Partials      495      495

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6816baf...ef73abc. Read the comment docs.

bonedaddy commented 4 years ago

@xiegeo I believe I have fixed the issue. The problem resides with the way rtns was handling bootstrapping according to the libp2p-kad-dht codebase in august 2019. Since then there's been a change to the boostrapping process, which subsequently required a modification to the way rtns handles bootstrapping.

I have made changes to rtns, and included teh dependency here. let me know if you need any clarification.

bonedaddy commented 4 years ago

I've deployed this to our development environment to see how it works out.