search

RTradeLtd / Temporal

☄️ Temporal is an easy-to-use, enterprise-grade interface into distributed and decentralized storage
https://temporal.cloud
MIT License
226 stars 40 forks source link

GET Uploads response not correctly labeling directories #457

Closed Vikkkkk closed 4 years ago

Vikkkkk commented 4 years ago

Describe the bug GET Uploads call returns Directory:false for a directory

To Reproduce Steps to reproduce the behavior:

  1. make the GET Uploads Api call
  2. View the response for a directory uploaded or upload a new directory
  3. See error

Expected behavior Should be Directory:True

bonedaddy commented 4 years ago

Thanks, working on this now. Looks like the way directory uploads are done via the web browser is different than the cli, so my current method of detection is working with cli, but not uploads through the new playground.

bonedaddy commented 4 years ago

Alright I talked with @DallasC and we're going to work around this by doing header detection for browser based directory upload. Specifically warp will now look for an X-IsDirectory header, if the recursive=true parameter detection fails

bonedaddy commented 4 years ago

This should be fixed now. Reopen if it happens again